Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symbols that can be used to surround a selection #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

symbols that can be used to surround a selection #3

wants to merge 1 commit into from

Conversation

dteskera
Copy link

@dteskera dteskera commented Oct 2, 2016

No description provided.

chachan
chachan suggested changes Oct 5, 2016
View reviewed changes
Copy link

@chachan chachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add ["{#", "#}"] as well?

@dteskera
Copy link
Author

dteskera commented Oct 6, 2016

it seems that multichar symbols can't be defined in surrounding pairs.
but maybe we could add ["#", "#"] as a surrounding pair and then we could have a 3 step inline commenting:

  1. select some text
  2. hit "{"
  3. hit "#"

@iambibhas
Copy link
Owner

I'm really late to this, but the characters introduced in surroundingPairs already close themselves as a feature of the editor, right? I can't test the effect of introducing it. I tried introducing # in the list and that didn't have any effect. I'd love some comments on what this PR does and some tests of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chachan chachan chachan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dteskera @iambibhas @chachan